Skip to content

adding a proper fractions algorithm #11224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 20, 2024
Merged

adding a proper fractions algorithm #11224

merged 10 commits into from
Mar 20, 2024

Conversation

meg-1
Copy link
Contributor

@meg-1 meg-1 commented Dec 27, 2023

Describe your change:

this algorithm returns a list of proper fractions, in the range between 0 and 1, which can be formed with the given denominator

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@meg-1
Copy link
Contributor Author

meg-1 commented Mar 15, 2024

Hi, @cclauss ! Would you please consider checking out and approving this pull request? Or perhaps you could share a list of other people with "write" permissions to this repository which I could contact?

cclauss
cclauss requested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that https://en.wikipedia.org/wiki/Function_(computer_programming) does not contain the word proper and a quick search for proper function returns a lot of unrelated links...

Please provide at least one URL in the docstring that defines proper function.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Mar 20, 2024
@cclauss cclauss added the awaiting changes A maintainer has requested changes to this PR label Mar 20, 2024
@cclauss cclauss requested a review from imSanko March 20, 2024 11:55
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed awaiting changes A maintainer has requested changes to this PR labels Mar 20, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Mar 20, 2024
@meg-1
Copy link
Contributor Author

meg-1 commented Mar 20, 2024

Given that https://en.wikipedia.org/wiki/Function_(computer_programming) does not contain the word proper and a quick search for proper function returns a lot of unrelated links...

Please provide at least one URL in the docstring that defines proper function.

Just implemented all changes recommended to the algorithm, thank you for the review, @cclauss! In addition to that, added a link with the purpose of clarifying what the algorithm's name proper_fractions means and what the algorithm works with.

cclauss
cclauss requested changes Mar 20, 2024
View reviewed changes
@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Mar 20, 2024
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Mar 20, 2024
@algorithms-keeper algorithms-keeper bot added the merge conflicts Open a new PR or rebase on the latest commit label Mar 20, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Mar 20, 2024
@algorithms-keeper algorithms-keeper bot removed the merge conflicts Open a new PR or rebase on the latest commit label Mar 20, 2024
@cclauss cclauss enabled auto-merge (squash) March 20, 2024 13:27
cclauss
cclauss approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks.

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Mar 20, 2024
@cclauss cclauss merged commit 8faf823 into TheAlgorithms:master Mar 20, 2024
3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Mar 20, 2024
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@meg-1 @cclauss
@pre-commit-ci @sedatguzelsemme
adding a proper fractions algorithm (TheAlgorithms#11224)
9cf883a 
* adding a proper fractions algorithm

* Implementing suggestions in maths/numerical_analysis/proper_fractions.py

Co-authored-by: Christian Clauss <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Implementing suggestions to proper_fractions.py

* Fixing ruff errors in proper_fractions.py

* Apply suggestions from code review

* ruff check --output-format=github .

* Update maths/numerical_analysis/proper_fractions.py

* Update proper_fractions.py

---------

Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@imSanko imSanko Awaiting requested review from imSanko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meg-1 @cclauss @imSanko